Skip to content

remove deprecated with await pool #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

remove deprecated with await pool #703

wants to merge 1 commit into from

Conversation

@Nothing4You
Copy link
Collaborator

What do these changes do?

Deprecated method Pool.get was removed
Deprecated with await pool syntax was removed.

Are there changes in behavior for the user?

Yes, see above.

Related issue number

no

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment to CHANGES.txt

@Nothing4You Nothing4You added this to the 1.0 milestone Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022 •
edited
Loading

Codecov Report

Merging #703 (4c555f3) into master (1558b4a) will decrease coverage by 0.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   86.50%   85.69%   -0.81%     
==========================================
  Files          12       12              
  Lines        2082     2076       -6     
  Branches      341      341              
==========================================
- Hits         1801     1779      -22     
- Misses        216      232      +16     
  Partials       65       65
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.2 82.22% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.10_mariadb-10.3 82.22% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.10_mariadb-10.4 82.22% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.10_mariadb-10.5 82.22% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.10_mariadb-10.6 82.22% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.10_mariadb-10.7 82.22% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.10_mysql-5.7 83.09% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.10_mysql-8.0 84.97% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.7_mariadb-10.2 81.75% <100.00%> (-0.85%) ⬇️
ubuntu-latest_3.7_mariadb-10.3 81.75% <100.00%> (-0.85%) ⬇️
ubuntu-latest_3.7_mariadb-10.4 81.75% <100.00%> (-0.85%) ⬇️
ubuntu-latest_3.7_mariadb-10.5 81.75% <100.00%> (-0.85%) ⬇️
ubuntu-latest_3.7_mariadb-10.6 81.75% <100.00%> (-0.85%) ⬇️
ubuntu-latest_3.7_mariadb-10.7 81.75% <100.00%> (-0.85%) ⬇️
ubuntu-latest_3.7_mysql-5.7 82.64% <100.00%> (-0.84%) ⬇️
ubuntu-latest_3.7_mysql-8.0 84.56% <100.00%> (-0.84%) ⬇️
ubuntu-latest_3.8_mariadb-10.2 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.8_mariadb-10.3 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.8_mariadb-10.4 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.8_mariadb-10.5 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.8_mariadb-10.6 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.8_mariadb-10.7 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.8_mysql-5.7 83.04% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.8_mysql-8.0 84.87% <100.00%> (?)
ubuntu-latest_3.9_mariadb-10.2 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.9_mariadb-10.3 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.9_mariadb-10.4 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.9_mariadb-10.5 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.9_mariadb-10.6 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.9_mariadb-10.7 82.17% <100.00%> (-0.83%) ⬇️
ubuntu-latest_3.9_mysql-5.7 83.04% <100.00%> (-0.82%) ⬇️
ubuntu-latest_3.9_mysql-8.0 84.87% <100.00%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiomysql/pool.py 96.87% <100.00%> (-0.12%) ⬇️
aiomysql/utils.py 71.57% <0.00%> (-16.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1558b4a...4c555f3. Read the comment docs.

@Nothing4You Nothing4You mentioned this pull request Jan 29, 2022
Closed
4 tasks
@Nothing4You Nothing4You force-pushed the remove-deprecations-pool branch from ab47f38 to ec58727 Compare January 29, 2022 02:46
@Nothing4You Nothing4You force-pushed the remove-deprecations-pool branch from ec58727 to 4c555f3 Compare January 29, 2022 02:48
@Nothing4You
Copy link
Collaborator Author

I'm not sure about the with await pool syntax - in aiopg's pool this is not deprected.
in aio-libs/aiopg#517 __iter__ was removed in favor of __await__, with (await pool) as conn seems to still be supported syntax.

@Nothing4You Nothing4You changed the title remove deprecated Pool.get and deprecated with await pool syntax remove deprecated Pool.get Jan 30, 2022
@Nothing4You Nothing4You changed the title remove deprecated Pool.get remove deprecated with await pool Jan 30, 2022
@Nothing4You
Copy link
Collaborator Author

Pool.get removal split to #706

@Nothing4You Nothing4You modified the milestones: 0.1, 1.0, 0.2 Feb 18, 2022
@Nothing4You Nothing4You marked this pull request as draft April 17, 2022 17:04
@Nothing4You Nothing4You modified the milestones: 0.2, 1.0 Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@Nothing4You